Opened 5 years ago

Closed 3 years ago

#2805 closed user story (fixed)

Support HDF5 1.10 and drop 1.6

Reported by: louiecn Owned by:
Priority: normal Milestone: Iteration I4
Component: core Keywords:
Cc: Estimated pair-hours remaining: 0
Pair-hours expended on ticket: 5 Initial estimate of effort: 16
Editable by public: yes

Description (last modified by louiecn)

Released on 31 March 2016.

Newsletter (PDF)

New features

Release notes

Changes (It doesn't actually look from this like there are many changes to get us. It's mostly new functionality.)

Before starting on this I strongly suggest we drop 1.6 and get the code working "natively" with 1.8. The first step will be removing the following bit that tells HDF5 to use the 1.6 API:

source:trunk/io/src/common/AbstractHdf5Access.hpp@25790#L39 (also present in Hdf5DataReader and Hdf5DataWriter)

Guess of time requirement is pessimistic. (Hopefully!)

Change History (13)

comment:1 Changed 5 years ago by louiecn

  • Description modified (diff)

comment:2 Changed 5 years ago by jonc@…

I agree to dropping 1.6 support.

comment:3 Changed 4 years ago by louiecn

  • Estimated pair-hours remaining changed from 16 to 8
  • Pair-hours expended on ticket changed from 0 to 1.25

HDF5 1.6 dropped in r26593. Was mostly a case of adding H5P_DEFAULT everywhere.

comment:4 Changed 4 years ago by louiecn

  • Description modified (diff)

comment:5 Changed 4 years ago by louiecn

  • Summary changed from HDF5 1.10 support to Support HDF5 1.10 and drop 1.6

comment:6 follow-up: Changed 4 years ago by GaryM

Entering TestResumeMonodomainProblemWithTargetChunkSizeAndAlignment
./heart/test/monodomain/TestMonodomainProblem.hpp:1755: Error: Expected (data_info.addr == 20567968u), found (20568008 != 20567968)
Failed

Sad face, but it is building now!

comment:7 in reply to: ↑ 6 Changed 4 years ago by louiecn

Replying to GaryM:

Sad face, but it is building now!

Thanks for the reminder, I'll add a tolerance to account for machine differences (comment:12:ticket:2789).

comment:8 Changed 4 years ago by GaryM

  • Editable by public set

comment:9 follow-up: Changed 4 years ago by fcooper

What's left to do on this ticket?

HDF5 1.10 is the default version available on Ubuntu 17.04, so would be good to get this working.

comment:10 in reply to: ↑ 9 Changed 4 years ago by louiecn

Replying to fcooper:

What's left to do on this ticket?

Just to keep an eye on the tests I think and make them more reliable if (when) there are machine differences. See comment:7.

comment:11 Changed 4 years ago by fcooper

Ok: I have compiled hdf5-1.10.0-patch1 (and, for that matter, hdf5-1.8.17 and hdf5-1.8.16) on Lofty, and added all three versions to the Lofty rotations.

Provided the tests pass, I'll change 1.10 from blue to light green on the dependency versions, and add in 1.8.16 and 1.8.17.

comment:12 Changed 4 years ago by fcooper

Hmm. May have spoken too soon. I'll revert them to blue.

comment:13 Changed 3 years ago by fcooper

  • Estimated pair-hours remaining changed from 8 to 0
  • Pair-hours expended on ticket changed from 1.25 to 5
  • Resolution set to fixed
  • Status changed from new to closed

1.10.0 and 1.10.1 are now both in the Portability Rotation with passing tests. The dependency versions page has been updated accordingly.

Note: See TracTickets for help on using tickets.