Opened 5 years ago

Closed 5 years ago

Last modified 23 months ago

#2726 closed user story (fixed)

Boost 1.59 compatibility

Reported by: GaryM Owned by:
Priority: normal Milestone: Iteration I3
Component: infrastructure Keywords:
Cc: Estimated pair-hours remaining: 0
Pair-hours expended on ticket: 2 Initial estimate of effort: 3
Editable by public: yes

Description

Boost 1.59 released: http://www.boost.org/users/history/version_1_59_0.html

No obvious changes to get us, but they do tend to hide them.

This ticket to test and put in to lofty rotation.

Change History (4)

comment:1 Changed 5 years ago by burgerga

Doesn't work, they removed pfto header from serialization so various files (https://github.com/Chaste/Chaste/search?utf8=%E2%9C%93&q=BOOST_PFTO) in chaste won't compile anymore.

Check the difference between 1.58 and 1.59: http://www.boost.org/doc/libs/1_58_0/boost/serialization/serialization.hpp http://www.boost.org/doc/libs/1_58_0/boost/serialization/pfto.hpp http://www.boost.org/doc/libs/1_59_0/boost/serialization/serialization.hpp

PS Is it possible to sync the svn to github again?

comment:2 Changed 5 years ago by GaryM

We'll have to check and see if we can work around it then, thanks for looking.

The svn and github should be in sync now (they get automatically synced when all the continuous tests are passing).

comment:3 Changed 5 years ago by GaryM

  • Pair-hours expended on ticket changed from 0 to 2
  • Resolution set to fixed
  • Status changed from new to closed

r25110 adds support for this - by simply removing the BOOST_PFTOs.

As far as I can work out these were boost's way of dealing with Partial Function Template Ordering for old compilers that didn't deal with it themselves. We were only using that in about half of the save_construct_data methods anyway. Taking it away doesn't appear to have broken anything, but we'll keep an eye on more obscure nightly builds.

I've added testing of 1.59 into the regular rotations in place of 1.49 which isn't in any currently supported Ubuntu any more, and updated InstallGuides/DependencyVersions accordingly.

comment:4 Changed 23 months ago by GaryM

  • Estimated pair-hours remaining changed from 3 to 0
Note: See TracTickets for help on using tickets.