Opened 7 years ago

Closed 6 years ago

#2469 closed user story (fixed)

Support VTK 6.x

Reported by: louiecn Owned by:
Priority: normal Milestone: Iteration I2
Component: infrastructure Keywords:
Cc: Estimated pair-hours remaining: 0
Pair-hours expended on ticket: 6.5 Initial estimate of effort: 4
Editable by public: yes

Description

See http://www.kitware.com/blog/home/post/515

and http://www.vtk.org/Wiki/VTK/VTK_6_Migration_Guide

Hopefully not too much has changed in the functionality we use.


Also just noticed this, related to #1157 ?

"The XDMF file format, which is a lightweight self describing layer over HDF5, is now a module in VTK."

Change History (7)

comment:1 Changed 7 years ago by GaryM

  • Component changed from - to infrastructure

comment:2 Changed 7 years ago by GaryM

comment:3 Changed 7 years ago by louiecn

  • Estimated pair-hours remaining changed from 4 to 2
  • Pair-hours expended on ticket changed from 0 to 2

I've been looking at this today. Changes committed in r21595 compile fine with VTK 6.0 for heart and cell_based by changing 7 instances of SetInput as justified here.

There are a couple to do in notforrelease_lung too.

Also note they've changed the library names. For the above I had to link against:

'vtkCommonCore-6.0','vtkCommonDataModel-6.0','vtkIOXML-6.0','vtkCommonExecutionModel-6.0','vtkFiltersCore-6.0','libvtkFiltersGeometry-6.0'

(for some reason they all got -6.0 appended to them when I built them). I found these laboriously with nm -c | grep (thanks Joe).

comment:4 follow-up: Changed 7 years ago by GaryM

Good work Louie, perhaps we should think about installing it on scoop and adding it to the rotations...

comment:5 in reply to: ↑ 4 Changed 7 years ago by louiecn

  • Pair-hours expended on ticket changed from 2 to 2.5

Replying to GaryM:

Good work Louie, perhaps we should think about installing it on scoop and adding it to the rotations...

Yes please.

I've done the same for notforrelease_lung in r21597 in case they're useful in future. I haven't tested them as the current guards are all for minor version >= 6, and I'm on minor version == 0, and can't be bothered to find/replace them all!

comment:6 Changed 6 years ago by louiecn

  • Editable by public set
  • Estimated pair-hours remaining changed from 2 to 0.5
  • Milestone changed from Future to Iteration I2
  • Pair-hours expended on ticket changed from 2.5 to 6

Hostconfig updated in r21627 for lofty@userpc59 to build against different versions of VTK (currently 5.10, 6.0, and 6.1). 5.10 checked and working. Still testing 6.x.

Todo: add the different versions to the test rotation.

VTK 6.1 had a conflict with ublas (over the meaning of detail), so we did some housekeeping in r21628 to remove most occurrences of using namespace.

comment:7 Changed 6 years ago by jonc@…

  • Estimated pair-hours remaining changed from 0.5 to 0
  • Pair-hours expended on ticket changed from 6 to 6.5
  • Resolution set to fixed
  • Status changed from new to closed

r21630 removes the only VTK 6.0 issue, and a test with 6.1 has passed all continuous tests successfully. r21632 added VTK 5.10, 6.0 and 6.1 to the lofty rotation, so I think we're done! Also updated LatestNews, InstallGuides/DependencyVersions and InstallGuides/TestingMultipleVersions.

Note: See TracTickets for help on using tickets.